makeplane
fix: removed sticky from first column header cell and data cell
Description
Removed sticky from first header cell and table data cells of first column.
Solves below issue: https://github.com/makeplane/plane/issues/7894
Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Feature (non-breaking change which adds functionality)
- [ ] Improvement (change that would cause existing functionality to not work as expected)
- [ ] Code refactoring
- [ ] Performance improvements
- [ ] Documentation update
Screenshots and Media (if applicable)
https://github.com/user-attachments/assets/a154d823-0499-4567-b9f1-45891b9867ad
Test Scenarios
References
Summary by CodeRabbit
- Style
- Adjusted spreadsheet header and first-column positioning and stacking behavior. This changes how header and row cells align and overlap during scrolling, reducing previous sticky offset and z-index stacking so cells remain relatively positioned and alter visual stacking order.
Walkthrough
Removed medium-screen sticky positioning and explicit left-offset/z-index classes from a header cell and a first table cell in the spreadsheet layout, reverting those elements to normal relative positioning while keeping other styles intact.
Changes
| Cohort / File(s) | Summary |
|---|---|
Spreadsheet header & row sticky removalapps/web/core/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx, apps/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx |
Deleted md:sticky (or equivalent medium-breakpoint sticky modifier), left-0, and z-[15] class values from the sticky header cell and first row cell so they no longer use sticky positioning or explicit stacking; other classes preserved. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
🐰 I nudged the sticky seam away,
Left the rows to hop and play,
No z-stack towers, calm and light,
A softer spreadsheet, simple sight. 🥕
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | You can run @coderabbitai generate docstrings to improve docstring coverage. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title Check | ✅ Passed | The pull request title "fix: removed sticky from first column header cell and data cell" directly corresponds to the actual changes made. The title clearly and specifically describes the primary modification: removing sticky positioning from both the header cell and data cells of the first column. The title is concise, uses the conventional "fix:" prefix, and provides sufficient specificity that a teammate can understand the main change without ambiguity. |
| Description Check | ✅ Passed | The pull request description follows the required template structure and includes most critical sections: a clear description of changes (removing sticky positioning from the first column), the type of change correctly marked as "Bug fix," a visual asset (screenshot/video) demonstrating the fix, and a reference to the related issue. The Test Scenarios section is left empty, which is a minor gap, but the description is otherwise complete and informative with concrete details about what was changed and why. |
✨ Finishing touches
- [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 347b6ad7252eede86b8077dd7ab578f26413f753 and 5213e1353183a47d8e7aff7050853f31ae609081.
📒 Files selected for processing (2)
apps/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx(1 hunks)apps/web/core/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/web/core/components/issues/issue-layouts/spreadsheet/spreadsheet-header.tsx
- apps/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is an intended behavior to help us understand which properties belong to which work item. That’s why it’s made sticky. However, these changes will create unintended consequences. Therefore, I’m closing this Pull request.
