[WEB-3926] chore: removed the duplicated webhook task and updated the webhook task to handle exceptions correctly
Description
This pull request cleans up duplicated code for the webhook task and also resolves the issue of multiple webhooks being triggered.
Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Code refactoring
Test Scenarios
- Each entity for which the webhook is triggered (issue, cycle, module etc)
References
Summary by CodeRabbit
- Chores
- Removed the feature that sent webhook notifications for issue activities. Webhook updates will no longer be triggered after issue activity creation.
[!WARNING]
Rate limit exceeded
@pablohashescobar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 38 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the
@coderabbitai reviewcommand as a PR comment. Alternatively, push new commits to this PR.We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
📥 Commits
Reviewing files that changed from the base of the PR and between 5e827228ce8818d2626713466be86c44047fe860 and a2c488ebe65311a700cc94473343bad364c6cd62.
📒 Files selected for processing (1)
apiserver/plane/bgtasks/webhook_task.py(10 hunks)
Walkthrough
The changes remove all logic related to dispatching and handling webhook events for issue activities. Specifically, the code that posted updates to the webhook system after creating issue activities has been deleted, as well as the entire Celery task responsible for sending webhook HTTP requests, handling retries, logging, and error management. Other functionalities, such as saving issue activities and sending notifications, remain unchanged.
Changes
| File(s) | Change Summary |
|---|---|
| apiserver/plane/bgtasks/issue_activities_task.py | Removed all logic that dispatched webhook events after bulk creation of issue activities. |
| apiserver/plane/bgtasks/webhook_task.py | Deleted the entire webhook_task Celery task, including all webhook sending, logging, and error handling. |
Poem
A rabbit hopped through fields of code,
And waved goodbye to webhooks' load.
No more tasks to retry or send,
The webhook journey meets its end.
Now lighter paws on simpler ground,
With less to break, and less confound!
🐇✨
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Pull Request Linked with Plane Work Items
- [WEB-3926] Remove the duplicated webhook function
Comment Automatically Generated by Plane