plane icon indicating copy to clipboard operation
plane copied to clipboard

fix: intake refactor

Open gakshita opened this issue 10 months ago • 1 comments

Description

This PR removes the unused intake actions and has some refactoring changes

Summary by CodeRabbit

  • New Features

    • Enhanced activity logs that now display clear information on the origin of work item creation.
    • Improved issue details with a refined display of creator information, including custom user names and profile links.
    • Introduced a new centralized access point for project inbox functionalities.
    • Added a new property to issue activity for detailed source data.
    • New component for displaying issue creator information based on activity context.
    • New export statements to enhance module accessibility.
  • Style

    • Updated the rich text editor’s styling with refined border and padding for a cleaner editing experience.
  • Refactor

    • Upgraded form handling to support multiple anchor values.
    • Streamlined inbox management by removing legacy publish and intake form functionalities.
    • Simplified feature settings for a more efficient configuration experience.

gakshita avatar Mar 04 '25 11:03 gakshita

Walkthrough

This update introduces several structural changes across multiple modules. A new type TAnchors is added, enhancing the TInboxForm to support multiple anchors. The TIssueActivity type now includes a source_data property for detailed activity information. The RichTextEditor styling has been adjusted, and a new component, IssueCreatorDisplay, has been created to conditionally render issue origins. Export statements have been added in various modules, and the parameter lists for rendering children have been simplified. Additionally, obsolete methods and state handling for intake forms have been removed, and some import paths have been updated.

Changes

File(s) Change Summary
packages/types/src/inbox.d.ts
packages/types/src/issues/activity/issue_activity.d.ts
Added exported type TAnchors and updated TInboxForm (replacing anchor with anchors: TAnchors); introduced source_data property in TIssueActivity with source details.
space/core/components/editor/rich-text-editor.tsx Modified editorClassName styling: changed border from border-gray-100/pb-3 to border-[0.5px] border-custom-border-200/py-2.
web/ce/components/issues/issue-details/index.ts
web/ce/components/issues/issue-details/issue-creator.tsx
web/ee/components/issues/issue-details/index.ts
web/ee/components/issues/issue-details/issue-creator.tsx
Added export statements for issue creator modules; introduced new React component IssueCreatorDisplay handling conditional rendering based on issue activity details.
web/ce/constants/project/settings/features.tsx
web/core/components/project/settings/features-list.tsx
Simplified the renderChildren function signature by reducing its parameters from four to two.
web/ce/store/project-inbox.store.ts
web/ee/store/project-inbox.store.ts
Created new store files to re-export entities from the project inbox module.
web/core/hooks/store/use-project-inbox.ts Updated the import path for IProjectInboxStore from the old module location to the new one.
web/core/services/inbox/inbox-issue.service.ts Removed three async methods (retrievePublishForm, updatePublishForm, regeneratePublishForm) and eliminated the associated TInboxForm type usage.
web/core/store/inbox/project-inbox.store.ts Removed the intakeForms property and its related methods (fetchIntakeForms, toggleIntakeForms, regenerateIntakeForms) from the project inbox store.
web/core/components/issues/issue-detail/issue-activity/activity/actions/default.tsx
web/core/components/issues/issue-detail/issue-activity/activity/actions/helpers/activity-block.tsx
Modified action rendering logic: conditionally displays messages based on the activity’s source and renders IssueCreatorDisplay when an issue is created without a field.

Suggested labels

⚙️backend, 🧹chore, 🌟improvement

Suggested reviewers

  • SatishGandham

Poem

In a burrow of code so deep,
I’ve hopped to change and tweak,
Anchors now multiply with glee,
And issues show their roots clearly.
My whiskers twitch with each commit—
A bunny’s code is truly lit!
🐇💻


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 760929ad9eca9851cf548337c8512b67ebc411d6 and 32628da16413f10a7edebb5ccdfc2e192f038982.

📒 Files selected for processing (1)
  • web/core/components/project/settings/features-list.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/core/components/project/settings/features-list.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 04 '25 11:03 coderabbitai[bot]