plane icon indicating copy to clipboard operation
plane copied to clipboard

[WEB-2588]fix: enabling guest user to use filters on their own views

Open vamsikrishnamathala opened this issue 1 year ago • 2 comments

Description

This update modifies the permissions to allow guest users to edit views if they are the owners. Additionally, it ensures that admins or owners continue to have editing permissions.

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Feature (non-breaking change which adds functionality)
  • [x] Improvement (change that would cause existing functionality to not work as expected)
  • [ ] Code refactoring
  • [ ] Performance improvements
  • [ ] Documentation update

References

WEB-2588

Summary by CodeRabbit

  • New Features

    • Enhanced user permission checks for project views.
    • Integrated user data to determine ownership and admin status.
  • Bug Fixes

    • Improved logic for enabling/disabling the FiltersDropdown based on user permissions.
  • Documentation

    • Updated method signatures for clarity on user data retrieval.

vamsikrishnamathala avatar Dec 23 '24 15:12 vamsikrishnamathala

Walkthrough

The pull request modifies the header.tsx file to improve user permission handling in a project view. The changes introduce a new useUser hook to retrieve user information and enhance access control logic. The modifications allow for more granular permission checks by considering both view ownership and admin status when determining user access to certain features like the FiltersDropdown component.

Changes

File Change Summary
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/views/(detail)/[viewId]/header.tsx Updated user permission checks using useUser hook, refined logic for FiltersDropdown component access based on user ownership and admin status

Possibly related PRs

  • #5589: Modifies header.tsx file with similar user permission check enhancements
  • #5898: Updates InboxContentRoot component to refine editability logic based on user permissions

Suggested labels

🌟enhancement

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • anmolsinghbhatia

Poem

🐰 Permissions dance, a rabbit's delight, Code weaves access with user might, Owners and admins, now clearly seen, Dropdown filters, a more nuanced scene, Coding magic, permission's new height! 🔐


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Dec 23 '24 15:12 coderabbitai[bot]

Pull Request Linked with Plane Issues

References

Comment Automatically Generated by Plane

makeplane[bot] avatar Jan 17 '25 08:01 makeplane[bot]