regression: Show the full screen toolbar option of images in read only instances as well
Description
Show the full screen toolbar option of images in read only instances as well!
Credits
Thanks mikhaella from discord for the catch!
Summary by CodeRabbit
-
New Features
- Improved logic for displaying image utilities and resizing options in the Custom Image Block.
- Introduced a dedicated control for managing the visibility of the image resizer.
-
Bug Fixes
- Streamlined conditions for showing image utilities, enhancing user experience when working with remote images.
Walkthrough
The changes made to the CustomImageBlock component in image-block.tsx involve updates to the logic governing the display of image utilities and resizing functionality. The condition for showing image utilities has been simplified, focusing solely on the presence of a remote image source and completion of the initial resize. Additionally, a new variable for managing the visibility of the image resizer has been introduced, and rendering logic has been adjusted accordingly.
Changes
| File Path | Change Summary |
|---|---|
| packages/editor/src/core/extensions/custom-image/components/image-block.tsx | Updated logic for displaying image utilities and resizing functionality; introduced showImageResizer variable; refined rendering conditions; updated types for ImageAttributes and Size; modified CustomImageBlock component. |
Possibly related PRs
-
#5623: Modifies the
CustomImageBlockcomponent's resizing functionality and introduces new state variables. -
#5686: Updates how the dimensions of the image are determined in the
CustomImageBlock. - #5693: Adds aspect ratio support for image attributes, relevant to the resizing functionality.
Suggested labels
🐛bug, 🌐frontend
Suggested reviewers
- SatishGandham
- aaryan610
- sriramveeraghanta
🐇 In the garden where images play,
A resizer hops, brightening the day.
With utilities now clear and bright,
Our images dance in the soft sunlight.
So let’s cheer for the code, oh so clever,
For resizing joy, we’ll hop on forever! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.