plane icon indicating copy to clipboard operation
plane copied to clipboard

[WEB-2393] chore-Uploading svg's are no more supported in the platform

Open Jimmycutie opened this issue 1 year ago • 1 comments

Clean Reason

Updated allowed image upload type. Removed .webp image upload and updated the accepting function to only allow jpg's and png.

Implementation

image image

References

[WEB-2393]

Summary by CodeRabbit

  • New Features

    • Updated image upload modals to accept only JPEG and PNG file formats.
    • Enhanced user interface text to clearly indicate supported formats: .jpeg, .jpg, and .png.
  • Bug Fixes

    • Removed support for previously accepted formats like SVG and WEBP to streamline user experience.

Jimmycutie avatar Sep 18 '24 12:09 Jimmycutie

Walkthrough

The pull request introduces changes to the image upload functionality across three components: ImagePickerPopover, UserImageUploadModal, and WorkspaceImageUploadModal. The modifications restrict accepted image file formats to only JPEG and PNG, explicitly removing support for WEBP and other formats. Corresponding user interface text has been updated to reflect these changes, ensuring clarity on the supported formats for users.

Changes

File Path Change Summary
web/core/components/core/image-picker-popover.tsx, web/core/components/core/modals/user-image-upload-modal.tsx, web/core/components/core/modals/workspace-image-upload-modal.tsx Updated accepted file formats to only JPEG and PNG; modified user interface text accordingly.

Possibly related PRs

  • #5582: This PR modifies the accepted image file formats in the ImagePickerPopover, UserImageUploadModal, and WorkspaceImageUploadModal components to remove support for .svg, aligning with the changes made in the main PR regarding accepted formats.

Suggested labels

🌟enhancement

Suggested reviewers

  • SatishGandham
  • anmolsinghbhatia

Poem

🐰 In a world of colors bright,
JPEG and PNG take flight.
WEBP has hopped away,
Now clearer paths for us to play.
With each upload, joy we find,
Simple formats, peace of mind! 🌈


Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between 244fb8acc8ed9f0ded3ade9c7bcff197f2c94c4a and 8ae106380a2c517483ccbc4b63a6d9e0dae6a6f6.

Files selected for processing (2)
  • web/core/components/core/image-picker-popover.tsx (3 hunks)
  • web/core/components/core/modals/user-image-upload-modal.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • web/core/components/core/image-picker-popover.tsx
  • web/core/components/core/modals/user-image-upload-modal.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- I pushed a fix in commit <commit_id>, please review it. -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples: -- @coderabbitai generate unit testing code for this file. -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- @coderabbitai generate interesting stats about this repository and render them as a table. -- @coderabbitai read src/utils.ts and generate unit testing code. -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 18 '24 12:09 coderabbitai[bot]