[WEB-2427] fix: white background behind emoji
[WEB-2427]
This PR implements design consistency for the Project Card View and Project Settings.
-
The project icon now has a translucent white background, across all themes, and the favourite icon is now rounded.
-
Previously only a white background was rendered behind the icon, across all themes
- Same translucent white background is not added to the project setting icon, which previously had a theme based background.
Summary by CodeRabbit
-
New Features
- Updated visual styles for the Project Card and Project Details Form components, enhancing the aesthetic appeal with modified background colors and button designs.
-
Bug Fixes
- Improved button visibility and user interaction through adjustments in color contrast.
Walkthrough
The changes involve aesthetic modifications to the ProjectCard and ProjectDetailsForm components. The background colors of specific elements have been adjusted to a more translucent shade, and the buttonClassName properties have been updated to include rounded corners. These adjustments are primarily visual and do not alter the functionality of the components.
Changes
| File | Change Summary |
|---|---|
| web/core/components/project/card.tsx | Updated background color of logo container from bg-white/90 to bg-white/10; modified buttonClassName for FavoriteStar to include rounded class. |
| web/core/components/project/form.tsx | Changed buttonClassName from bg-custom-background-90 to bg-white/10 in ProjectDetailsForm. |
Possibly related PRs
- #5562: Similar modification to the
buttonClassNameproperty in theProjectDetailsFormcomponent. - #5568: Includes visual adjustments and layout improvements for related project components.
- #5572: Involves layout restructuring in the
ProjectSettingLayoutcomponent, potentially connected to the styling changes.
Suggested labels
🌐web
Poem
In a world of colors bright,
A logo's glow now feels just right.
With buttons rounded, soft and true,
A subtle touch, a lovely view.
Hoppy changes, oh so sweet,
A visual treat, a design complete! 🐰✨
Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL
Commits
Files that changed from the base of the PR and between 146a500f9f7fcddd1b57833fe7de8c86ebfc9cb3 and 5258a3d32790da1ff1cff558d30141531336f249.
Files selected for processing (2)
- web/core/components/project/card.tsx (2 hunks)
- web/core/components/project/form.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- web/core/components/project/card.tsx
Additional comments not posted (1)
web/core/components/project/form.tsx (1)
158-158: Approve the button background color update.The change from
bg-custom-background-90tobg-white/10for thebuttonClassNameprop ofCustomEmojiIconPickeris a good improvement. It introduces a translucent white background for the project icon button, which aligns with the PR objective of ensuring design consistency across all themes. The translucent background allows the underlying theme to partially show through, enhancing visual harmony.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
--
I pushed a fix in commit <commit_id>, please review it.--Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples: --@coderabbitai generate unit testing code for this file.--@coderabbitai modularize this function. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: --@coderabbitai generate interesting stats about this repository and render them as a table.--@coderabbitai read src/utils.ts and generate unit testing code.--@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.--@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.