plane icon indicating copy to clipboard operation
plane copied to clipboard

fix: drag handle scrolling fixed

Open Palanikannan1437 opened this issue 1 year ago • 1 comments

Description

Added dynamic scrolling in Pages such that you could scroll easily while dragging and dropping nodes.

Summary by CodeRabbit

  • New Features
    • Enhanced drag-and-drop functionality with improved scrolling behavior when dragging elements.
    • Exported new utility functions for identifying scrollable elements and handling drag events more effectively.
  • Improvements
    • Adjusted scrolling thresholds in the side menu for a more responsive user experience.
    • Minor code adjustments for better clarity and performance.

Palanikannan1437 avatar Sep 16 '24 14:09 Palanikannan1437

Walkthrough

The pull request modifies the SideMenuExtension in the side-menu.tsx file by changing the upward scrollThreshold from 300 to 200. In the drag-handle.ts file, it exports the nodeDOMAtCoords function to enhance drag-and-drop functionality, allowing for the identification of various node types. Additionally, new utility functions for scroll detection are introduced, improving the drag experience. Minor adjustments include the removal of unused variables and added comments, while maintaining the overall structure and responsiveness.

Changes

File Path Change Summary
packages/editor/src/core/extensions/side-menu.tsx Adjusted scrollThreshold for upward scrolling from 300 to 200.
packages/editor/src/core/plugins/drag-handle.ts Exported nodeDOMAtCoords function; added isScrollable and getScrollParent functions; modified drag handling logic for improved scrolling behavior. Removed unused variable and added comments.

Possibly related PRs

  • #5329: Refactors the editor side menu, directly related to changes in the SideMenuExtension.
  • #5349: Modifies the SideMenu function to enhance interaction with drag-and-drop events, connecting to scrolling behavior adjustments.
  • #5371: Refactors the editor side menu and adds support for an AI handle, aligning with modifications to the SideMenuExtension.
  • #5400: Refactors the editor side menu to enhance functionality, closely related to the SideMenuExtension changes.
  • #5687: Addresses rendering logic of the side menu to prevent multiple instances, relevant to the SideMenuExtension behavior.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

  • SatishGandham
  • aaryan610

Poem

In the editor's cozy den,
The side menu scrolls again.
With drag and drop, it glides so free,
A smoother path for you and me.
Hops and jumps, a joyful spree,
Thanks to changes, let it be! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 16 '24 14:09 coderabbitai[bot]