[WEB-2455] fix: Quick action menu is overflowing for created link notification under inbox
Problem Statement
Quick action menu on hover was overflowing for created and updated link notifications in inbox.
Solution
When the links were long the words weren't wrapping correctly inside the div which lead it to push the menu items to right and made them overflow. The wrap text property was set to word which only wrapped whole words. Changing it to all fixed the issue.
Screenshots and Media
Before:
After:
References
Summary by CodeRabbit
- New Features
- Improved readability of notification messages by allowing text to break at any character, preventing overflow in the notification card.
Walkthrough
The changes in this pull request involve a modification to the NotificationItem component's CSS class. The whitespace-normal class has been updated to whitespace-normal break-all, which alters how text is displayed in notification messages. This adjustment allows for word breaks at any character, improving the handling of lengthy messages within the notification card.
Changes
| File Path | Change Summary |
|---|---|
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx |
Updated CSS class from whitespace-normal to whitespace-normal break-all for better text handling in notifications. |
Possibly related PRs
- #5559: Changes in the
HeaderGroupByCardcomponent also involve modifications to class names applied todivelements, indicating a similar focus on visual presentation adjustments.
Suggested labels
🐛bug, 🌐frontend, 🌐web
Poem
In the land of code where bunnies play,
A change was made to brighten the day.
With words that break and fit just right,
Notifications now bring pure delight!
Hopping through messages, clear and bright,
Our little changes make everything light! 🐇✨
[!TIP]
OpenAI O1 model for chat
- We have deployed OpenAI's latest O1 model for chat.
- OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
- Please share any feedback with us in the discussions post.
Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL
Commits
Files that changed from the base of the PR and between f155a13929991453052ebd9e1b9b79424ffb74db and 1ec6c5bf706e718e9ad04ca6e8e2a0c3a3deba4c.
Files selected for processing (1)
- web/core/components/workspace-notifications/sidebar/notification-card/item.tsx (1 hunks)
Additional comments not posted (1)
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx (1)
89-89: LGTM!The change from
whitespace-normaltowhitespace-normal break-allis a good fix for the quick action menu overflow issue. It allows text to break at any character, ensuring that longer messages fit within the designated area without overflowing.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
The issue with comment activity is still occurring. Could you please take a look at it?
![]()
The fix is working for every type of notification.