plane icon indicating copy to clipboard operation
plane copied to clipboard

[WEB-2282] fix: date picker and member picker dropdown z-index for list, kanban and spreadsheet views

Open sharma01ketan opened this issue 1 year ago • 1 comments

[WEB-2282]

Notes:

  • z-10 is chosen for list and gantt view: It was the value prior to the commit which introduced this bug.

  • z-9 for spreadsheet: because value of z-10 solved the issue for vertical scrolling only but not for horizontal scrolling, So the value had to be reduced further.

  • Day Picker refers to both start and end/due date here.

Changes:

List View:

  • Date picker does not overlap the header now. Screenshot 2024-09-09 at 3 23 22 PM

  • Assignees Dropdown does not overlap the header now

Screenshot 2024-09-09 at 3 24 46 PM

Kanban View:

  • No overlapping with sidebar Screenshot 2024-09-09 at 3 25 03 PM Screenshot 2024-09-09 at 3 25 35 PM

Spreadsheet View:

  • Same for Spreadsheet View.
Screenshot 2024-09-09 at 3 27 59 PM Screenshot 2024-09-09 at 3 28 33 PM

Previous State:

  • List View
Screenshot 2024-09-09 at 3 34 08 PM
  • Kanban View
Screenshot 2024-09-09 at 3 34 20 PM
  • Spreadsheet
Screenshot 2024-09-09 at 3 34 30 PM

Reference: [WEB-2282]

Summary by CodeRabbit

  • New Features

    • Enhanced DateDropdown and MemberDropdown components to accept a customizable className prop for improved styling flexibility.
    • Introduced a dynamic class name assignment for better reusability and customization options.
  • Bug Fixes

    • No specific bug fixes were included in this release.
  • Documentation

    • Updated component documentation to reflect the addition of the className prop and its usage.

sharma01ketan avatar Sep 09 '24 10:09 sharma01ketan

Walkthrough

The pull request introduces modifications to several dropdown components within the codebase. Key changes include the addition of a className prop in the DateDropdown, MemberDropdown, and MemberOptions components, enhancing styling flexibility. Additionally, z-index classes have been added to various spreadsheet column components to adjust their stacking order. These updates improve the adaptability and visual layering of the components without altering their core functionality.

Changes

File Path Change Summary
web/core/components/dropdowns/date.tsx Modified DateDropdown to use dynamic class names via className prop for enhanced styling flexibility.
web/core/components/dropdowns/member/index.tsx Added className prop to MemberOptions component within MemberDropdown for improved styling options.
web/core/components/dropdowns/member/member-options.tsx Added optional className to Props interface in MemberOptions, allowing for custom class name usage.
web/core/components/issues/issue-layouts/properties/all-properties.tsx Updated button elements to include additional class "z-10" for visual layering.
web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx Added className="z-9" to SpreadsheetAssigneeColumn for stacking order adjustment.
web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx Added className="z-9" to SpreadsheetDueDateColumn for stacking order adjustment.
web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx Added className="z-9" to SpreadsheetStartDateColumn for stacking order adjustment.

Possibly related PRs

  • #5546: The changes in the DateDropdown component regarding dynamic class name assignment are related to the addition of the className prop in the MemberDropdown and MemberOptions components, which similarly enhance styling flexibility.

Suggested labels

🌟improvement

Poem

🐇 In the meadow where the dropdowns play,
A sprinkle of class names brightens the day.
With z-index magic, they leap and they bound,
Enhancing the layers, all snug and sound.
Hooray for the changes, let’s hop and rejoice,
For every new feature, we cheer and we voice! 🎉

[!TIP]

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 09 '24 10:09 coderabbitai[bot]