[WEB-2390] fix: Clickable Area for Issue List Layout Item
Problem Statement
The current issue list layout only allows the title of each item to be clickable.
Solution
Moved Control function block to cover the whole issue block element instead of the inner title element.
Screenshots and Media
https://github.com/user-attachments/assets/89c93642-8ada-4815-92ca-8e01786b5b31
References
Summary by CodeRabbit
-
New Features
- The
IssueBlockcomponent is now a clickable link that navigates to the issue overview, enhancing interactivity. - The
RelationIssueListItemandIssueListItemcomponents have been updated to make the entire area clickable for improved user interaction.
- The
-
Bug Fixes
- Preserved drag-and-drop functionality while ensuring the visual and functional aspects remain consistent.
-
Improvements
- Enhanced organization and readability of components by restructuring layouts.
- Adjusted layout for issue properties and quick actions to maintain responsiveness with the sidebar's state.
Walkthrough
The changes involve refactoring multiple components by replacing existing structural elements with ControlLink components. This adjustment allows entire areas of the components to become clickable links, enhancing navigation to issue details. The internal structures and functionalities of the components are preserved, ensuring that properties, event handlers, and layouts remain consistent while improving interactivity.
Changes
| Files | Change Summary |
|---|---|
web/core/components/issues/issue-layouts/list/block.tsx, web/core/components/issues/relations/issue-list-item.tsx, web/core/components/issues/sub-issues/issue-list-item.tsx |
Refactored components to replace structural elements with ControlLink, enhancing clickability while maintaining existing properties, event handlers, and layouts. |
web/core/components/workspace-notifications/sidebar/notification-card/item.tsx |
Modified CSS class for a div element to change text handling, improving word wrapping and overflow behavior. |
Possibly related PRs
- #5559: The changes in the
RelationIssueListItemcomponent involve restructuring the JSX layout to enhance organization and readability, similar to the structural changes made in theIssueBlockcomponent in the main PR. - #5568: The modifications in the
IssueModuleSelectcomponent include adding aclassNameprop, which aligns with the changes in theIssueBlockcomponent that also focus on enhancing the component's structure and interactivity. - #5639: The adjustments in the
ListGroupcomponent to improve the quick action menu's styling relate to the overall enhancements in user interface and interaction models seen in theIssueBlockcomponent changes. - #5647: The performance optimizations in the
RenderIfVisiblecomponent, particularly for the Kanban layout, connect to the structural and functional improvements made in theIssueBlockcomponent, as both aim to enhance user experience and responsiveness.
Suggested labels
🌟improvement
Poem
🐇 In the meadow where issues play,
A link was born to light the way.
With a hop and a skip, it calls you near,
Click and explore, there's nothing to fear!
A new path to follow, so bright and so bold,
Join the adventure, let the stories unfold! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
--
I pushed a fix in commit <commit_id>, please review it.--Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples: --@coderabbitai generate unit testing code for this file.--@coderabbitai modularize this function. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: --@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.--@coderabbitai read src/utils.ts and generate unit testing code.--@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.--@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@Jimmycutie The code changes look fine. Since you have moved the ControlLink to the parent level, could you please confirm if the following edge cases work fine,
- The dropdowns open and close just fine in all three components
- In case of the list layout the drag and drop works fine
- In case of list layout Opening of peek overview in draft issues
- In case of list layout selection of issues in EE work fine
Yes, I have checked these edge cases and It's functioning fine.