plane icon indicating copy to clipboard operation
plane copied to clipboard

[WEB-2106] fix: add date and state change functionalities to list and grid view

Open sharma01ketan opened this issue 1 year ago • 1 comments

This PR introduces the ability to change the state and date of Module from list and grid view. Previously possible via edit and info button only. All the styling is made similar to the date picker present in the cycles view.

Changes:

LIST VIEW:

  • Date Picker Screenshot 2024-09-05 at 5 59 50 PM

  • Status Selector Screenshot 2024-09-05 at 6 00 00 PM

GRID VIEW:

  • Date Picker Screenshot 2024-09-05 at 6 06 41 PM

  • Status Selector Screenshot 2024-09-05 at 6 07 04 PM

STYLING DETAILS:

LIST VIEW:

  • With Date (once date is set) v/s No Date ( default state when new module is created) Screenshot 2024-09-05 at 6 36 23 PM

GRID VIEW:

  • With Date (once date is set) v/s No Date ( default state when new module is created) Screenshot 2024-09-05 at 6 09 27 PM

CYCLES:

  • Cycles' styling for comparison Screenshot 2024-09-05 at 6 37 18 PM

ARCHIVED MODULES:

  • The cursor shows "disable" when hovered over an archived module status and date picker.

https://github.com/user-attachments/assets/fd0e7578-23e6-4316-9c77-e8d847e591eb

Reference:

[WEB-2106]

Summary by CodeRabbit

  • New Features
    • Introduced a DateRangeDropdown for selecting start and end dates for modules, improving user interaction.
    • Added a new ModuleStatusSelection component for managing module statuses with enhanced visual cues.
  • Enhancements
    • Improved feedback during updates with toast notifications for success and error handling.
    • Refined logic to control user permissions for editing modules based on roles and module status.
  • Bug Fixes
    • Removed unused imports and optimized state management for better performance.

sharma01ketan avatar Sep 05 '24 13:09 sharma01ketan

Walkthrough

The changes involve significant updates to the ModuleCardItem, ModuleListItemAction, and the newly introduced ModuleStatusDropdown components. Enhancements include the integration of a DateRangeDropdown for date selection, improved asynchronous handling of module details updates, and refined state management to control user interactions based on permissions and module status.

Changes

Files Change Summary
web/core/components/modules/module-card-item.tsx Updated imports, added DateRangeDropdown, enhanced handleModuleDetailsChange for asynchronous updates, refined interactivity logic with isDisabled.
web/core/components/modules/module-list-item-action.tsx Removed unused imports, integrated DateRangeDropdown, expanded handleModuleDetailsChange for status updates, refined state management with isDisabled.
web/core/components/modules/module-status-dropdown.tsx Introduced ModuleStatusDropdown component for module status selection, utilizing MobX for state management and a custom select component for user interaction.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ModuleCardItem
    participant ModuleListItemAction
    participant ModuleStatusDropdown
    participant useModule

    User->>ModuleCardItem: Select date range
    ModuleCardItem->>useModule: updateModuleDetails(dateRange)
    useModule-->>ModuleCardItem: Success/Error notification
    ModuleCardItem->>User: Display notification

    User->>ModuleListItemAction: Change module status
    ModuleListItemAction->>useModule: updateModuleDetails(newStatus)
    useModule-->>ModuleListItemAction: Success/Error notification
    ModuleListItemAction->>User: Display notification

    User->>ModuleStatusDropdown: Select new status
    ModuleStatusDropdown->>useModule: updateModuleDetails(newStatus)
    useModule-->>ModuleStatusDropdown: Success/Error notification
    ModuleStatusDropdown->>User: Display notification

Poem

🐇 In a meadow bright and wide,
New features hop, they leap, they glide.
With dates to pick and statuses clear,
Our modules dance, bringing cheer!
So let us click and change with glee,
For updates bring us joy, you see! 🌼

[!TIP]

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 05 '24 13:09 coderabbitai[bot]