plane icon indicating copy to clipboard operation
plane copied to clipboard

[feature]: uploads to s3 bucket should be private

Open dylanvaughn opened this issue 10 months ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Summary

While testing the current self-hosted installation, using the AWS S3 integration, I noticed that all uploaded files in the application were set as publicly readable. This means that attachments on an issue could be viewed by anyone if they had the URL.

Instead, if S3 integration is enabled, the objects should be private, and there should be a method in the application to authenticate the request for an asset (i.e. the logged in user has access to the issue the asset is attached to, for example), and then stream the object from S3.

Why should this be worked on?

This would improve the security posture of the application. Currently I think it is too risky to use the s3 integration if all files are marked as publicly readable. If there is a configuration option I am missing here to make the s3 objects private please let me know :).

dylanvaughn avatar Apr 13 '24 06:04 dylanvaughn

Hello @dylanvaughn ,

We are working on making these assets private, but the problem is migrating the existing data safely. We are working on a few solutions to make this a smooth transition. We will keep you posted soon.

sriramveeraghanta avatar Apr 15 '24 07:04 sriramveeraghanta

I hope the function to use s3 private will come out soon.

Huy-Nhan avatar May 15 '24 15:05 Huy-Nhan

Hi @Huy-Nhan, Yes we are working towards releasing this out as soon as possible.

pushya22 avatar May 15 '24 15:05 pushya22

Do we have any updates or ETA on this? 🤔

akumar-99 avatar Sep 16 '24 13:09 akumar-99

We understand the security concerns regarding this issue, and we’re happy to report that all our storage now is on private S3 on our Cloud environments. Thank you for your patience.

vihar avatar Oct 13 '24 19:10 vihar

Thanks @vihar . Will this come to self-hosted as well? I believe this issue is for self-hosted. #5145 is for cloud.

leedsjb avatar Oct 13 '24 22:10 leedsjb

We will be shipping this to self-hosted instances in the upcoming release v0.24.0

sriramveeraghanta avatar Oct 14 '24 09:10 sriramveeraghanta