plane icon indicating copy to clipboard operation
plane copied to clipboard
Published 19 hours ago • verified publisher icon makeplane

Feat/Refresh s3 links in projects and issues

Open daniel-alba17 opened this issue 2 years ago • 3 comments

  • Issue: https://github.com/makeplane/plane/issues/3161

🎯 Milestone

Refresh s3 links in issue body and project cover if bucket is private

🛠 Changes

  • Create a new class for S3 actions (upload, delete, referesh url)
  • Create method for verify if a link is a S3 link
  • Create method for verify if a S3 link has expired
  • Create method to parse html to html object
  • Create class in serialzers for update S3 links
  • Add AWS_S3_BUCKET_AUTH, AWS_S3_MAX_AGE_SECONDS and AWS_S3_SIGNATURE_VERSION in settings.common file

daniel-alba17 avatar Dec 16 '23 04:12 daniel-alba17

@daniel-alba17, thanks for creating the PR we will review this and get back.

pablohashescobar avatar Dec 18 '23 18:12 pablohashescobar

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: daniel-alba17
:x: daniel

daniel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 08 '24 10:02 CLAassistant

There is a new issue https://github.com/makeplane/plane/issues/4248 about that last error

vansergen avatar Apr 28 '24 00:04 vansergen