plane icon indicating copy to clipboard operation
plane copied to clipboard

remove noHeader prop & show navigation as burger menu on [workspaceSlug] page, mobile screens

Open kblueberry opened this issue 1 year ago • 1 comments

This is a fix to bug #1332 [bug]: Unable to navigate via mobile on [workspaceSlug] page

kblueberry avatar Jun 23 '23 10:06 kblueberry

@kblueberry is attempting to deploy a commit to the Plane Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 23 '23 10:06 vercel[bot]

@aaryan610 hi! Pls, check this PR PWA mode also broken, cuz I can'n navigate anywhere (in browser I can manualy change url to '/projects' and navigate to projects page where navigation drawer works fine)

redzumi avatar Jun 24 '23 09:06 redzumi

Hi @kblueberry, thanks for your contribution to this bug. But, the approach used by you won't be feasible, as it will add an unnecessary topbar on the workspace dashboard.

Thanks for bringing this bug to our attention. It will be fixed once PR #1389 is merged.

aaryan610 avatar Jun 24 '23 10:06 aaryan610

@aaryan610 thank you! By the way, does the plane have design guidelines? Possibly, @kblueberry could fix things like this by herself in future

redzumi avatar Jun 24 '23 10:06 redzumi

@redzumi we are actively working on creating a well structured documentation for our contributors and we plan to release it soon.

aaryan610 avatar Jun 24 '23 10:06 aaryan610

@aaryan610 thanks for the help and replies!

redzumi avatar Jun 24 '23 10:06 redzumi