plane icon indicating copy to clipboard operation
plane copied to clipboard

[bug]: Unable to navigate via mobile on [workspaceSlug] page

Open redzumi opened this issue 1 year ago • 7 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current behavior

WorkspaceAuthorizationLayout has noHeader prop, so I can't open drawer to navigate

Снимок экрана 2023-06-20 в 00 50 52

If I misunderstood something in UX, please let me know PS Thanks for great and opensource service!

Steps to reproduce

  1. Open [workspaceSlug] page via mobile view

Browser

Google Chrome

Version

Cloud

redzumi avatar Jun 19 '23 21:06 redzumi

I am new to this project, I would like to take this bug into development, as I see, nobody is working on it, right? May I ask anybody, is there any design resources which I can rely on? Thanks in advance

kblueberry avatar Jun 21 '23 10:06 kblueberry

@rhea0110 hi! Pls, help with design for this issue @kblueberry can fix it, but it's okay, to show navigation header at index page of project?

redzumi avatar Jun 22 '23 19:06 redzumi

Hello @kblueberry,

Thank you for showing interest in contributing to our project. We're pleased to assign this issue to you!

We currently have a sidebar toggle feature and we're considering how it can be best implemented for mobile screens. Your feedback and insights on this matter would be invaluable.

CleanShot 2023-06-23 at 00 49 41@2x

vihar avatar Jun 22 '23 19:06 vihar

Hello @vihar , thanks for reply. I was thinking about burger menu, which is expanding/collapsing on icon click, or about bottom naviation with icons which indicates ceratin section. What do you think?

kblueberry avatar Jun 23 '23 09:06 kblueberry

@kblueberry @vihar 123 Can we just remove noHeader prop from WorkspacePage component?

redzumi avatar Jun 23 '23 10:06 redzumi

Looks like it could be a decision, and we already see the burger menu working without noHeader prop

kblueberry avatar Jun 23 '23 10:06 kblueberry

This bug will be fixed, once PR #1389 is merged.

aaryan610 avatar Jun 24 '23 10:06 aaryan610

Yea, fixed!

redzumi avatar Jul 04 '23 15:07 redzumi