plane icon indicating copy to clipboard operation
plane copied to clipboard

[bug]: Change Cover button is missing on self-hosted version

Open mikhail-shevtsov-wiregate opened this issue 1 year ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current behavior

On latest release v0.7.1 when creating new project or editing project Change Cover button is missing on self-hosted version.

Steps to reproduce

  1. Go to Projects;
  2. Click Add Project button; or
  3. Go to Project Settings;

In both cases the button Change Cover is Missing

Browser

Mozilla Firefox

Version

Self-hosted

Yes, mine also not showing

ChandanJal avatar Jun 12 '23 06:06 ChandanJal

Hey @mikhail-shevtsov-wiregate, thank you for reporting this bug. Our engineers have already started working on fixing this issue, and it will be live in some time. We will keep you updated on the progress made.

Thank you!

rhea0110 avatar Jun 12 '23 07:06 rhea0110

I found the reason.

The environment variables read via process.env.NEXT_PUBLIC_UNSPLASH_ENABLED are build-time variables, not run-time. https://github.com/makeplane/plane/blob/61672f47ac9f027be95b968378596048e03d1c4e/web/components/core/image-picker-popover.tsx#L24-L26


I suggested that use Next Runtime Config^1 to pass it.

By using this, we will not need to use this script to change NEXT_PUBLIC_API_BASE_URL any more. https://github.com/makeplane/plane/blob/61672f47ac9f027be95b968378596048e03d1c4e/replace-env-vars.sh#L5-L15

I'm willing to submit a PR to implement it.

ix64 avatar Sep 13 '23 08:09 ix64

thanks for flagging this, @mikhail-shevtsov-wiregate. this issue is fixed on https://github.com/makeplane/plane/pull/2375.

vihar avatar Dec 13 '23 20:12 vihar