sandi_meter icon indicating copy to clipboard operation
sandi_meter copied to clipboard

Exits with code 1 even when below (above?) thresholds

Open jgrau opened this issue 7 years ago • 0 comments

First of all thanks for making this gem. I love static analysis and I love Sandi Metz :)

I see the following behaviour:

❯ bundle exec sandi_meter -v
Ⓢ ⓐ ⓝ ⓓ ⓘ Ⓜ ⓔ ⓣ ⓔ ⓡ  1.2.0

❯ bundle exec sandi_meter -t '10,10,10,10' -p app -q
1. 98% of classes are under 100 lines.
2. 75% of methods are under 5 lines.
3. 99% of method calls accepted are less than 4 parameters.
4. 100% of controllers have one instance variable per action.

❯ echo $?
1

Shouldn't the exit code be 0 when my app performs better than the thresholds?

jgrau avatar Aug 18 '17 07:08 jgrau