Text-CSV icon indicating copy to clipboard operation
Text-CSV copied to clipboard

Remove bad STDOUT mention

Open jidanni opened this issue 4 years ago • 2 comments

We read "out" can be a file name (e.g. "file.csv"), which will be opened for writing and closed when finished, a file handle (e.g. $fh or "FH"), a reference to a glob (e.g. "*STDOUT"), the glob itself (e.g. *STDOUT), " That's right. So I removed the invalid line.

jidanni avatar Feb 20 '21 05:02 jidanni

Hazards: creates ./STDOUT file, and if use strict: makes warnings.

jidanni avatar Feb 20 '21 05:02 jidanni

I didn't edit the _PP version. Please do if needed.

jidanni avatar Feb 20 '21 05:02 jidanni

Could you make a PR for https://github.com/Tux/Text-CSV_XS if this still matters to you? The doc of Text::CSV(_PP) is copied from there.

Note also: when perl encounters csv(in => $aoa, out => STDOUT);, it spits an error if strict ( Bareword "STDOUT" not allowed while "strict subs" in use ) but it writes to a file called STDOUT if not strict. So, whether the line is invalid or not depends on the mode.

charsbar avatar Dec 02 '23 12:12 charsbar

There should be some warnings in the file "Don't edit this, edit the master version."

That way years later, there would be no need to ask the original PR submitter (e.g., me) who by that time has lost all concept of what was going on... So sorry.

jidanni avatar Dec 04 '23 08:12 jidanni