Michael Jordan

Results 34 comments of Michael Jordan

I think ideally we would compensate for the lack of announcement of the invalid state change using LiveAnnouncer, and clarify why the range is invalid. Something like “end date comes...

@kherock You may also want to consider https://github.com/adobe/react-spectrum/pull/2445. It adds support for passing a `RefObject` to the `FocusScope`'s `restoreFocus` prop, which is similar to how you have implemented `tabOrder`. It...

> This seems to work well enough. I'm a bit concerned about how the scrolling may close dropdowns/popovers which could pose a problem for react-aria users who use `useOverlayPosition`, specifically...

> This issue is not specific to Virtualizer. For example, use your same reproduction steps on [this example](https://reactspectrum.blob.core.windows.net/reactspectrum/0661785f30971bdbcbd291282b26836cf272c3f8/storybook/iframe.html?id=useselectablelist--static-ul-static-sub-ul&providerSwitcher-locale=&providerSwitcher-theme=&providerSwitcher-scale=&providerSwitcher-toastPosition=bottom&viewMode=story). > > The root cause is that we use `focusSafely` [here](https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/selection/src/useSelectableItem.ts#L117), which...

> I don't follow. Popovers should never extend beyond the viewport. The content of the popover itself is scrollable, not the document body. > > Regardless, closing on scroll has...

@devongovett I wonder if I should revert the `IntersectionObserver` logic back to to the `Virtualizer`, rather than `focusSafely`, or make it a separate hook that gets added as needed to...

@devongovett and @LFDanLu What I'm trying to say is that the `shouldFlip:false` and `position: bottom` use case Daniel describes above would be a broken experience even without the changes in...

@solimant I agree with @snowystinger that the default Algolia search results have accessibility problems, for example each returned result in the listbox is announced as `"Link to the result"` due...

Also, if we ever wanted to localize our docs, with these hard-coded strings, Algolia clearly hasn't considered that.

Issue filed with Algolia: https://github.com/algolia/docsearch/issues/1014