os checks before run + rhel 7 fixes for grub

[Trikke76]

you probably don't want to auto merge this one as i have changed the layout a lot this way the ansible role will be more user friendly for others.

you probably want to check the files tasks/main.yml and the tasks/section_01_level1.yml files and do a manual merge

i will update more for rhel 7 let me know if you want me to do a pull request or not as our role are very different.

[major]

Whoa, these are some big changes. The PR removes tests among other things. Would it be possible to rebase your changes so they're less destructive?

[shawnsi]

This directory structure was the result of https://github.com/major/cis-rhel-ansible/issues/17. The PR in question here doesn't follow that design.

@major Shouldn't @Trikke76 move his work to https://github.com/major/ansible-role-cis?

[Trikke76]

https://github.com/major/ansible-role-cis looks much better the weird directory structure was the reason i did the changes. travis test where removed as travis only runs debian so for a centos/redhat role this is was not realy functional. i could move to the other repo and check changes i made i guess this will be more productive

[major]

Ah yeah. There was a push from users to move the role into this repository to make things easier. I plan to deprecate the ansible-role-cis repository ASAP since this repository has moved forward without it.

Sorry for the confusion.

[Trikke76]

that's weird the ansible-role-cis is much easier for users to work with all roles in ansible galaxy are maintained this way as far as i know.

also the travis testing is of no use as travis only runs debian and the test will fail one you check for the os before the playbook runs.

I will look for a easy way to clone your role and integrate it in my system it will make things more easy to push and merge.

how far is the other repo behind ? if not to far i prefer to clone this one and push updates or maintain it myself.

[major]

@Trikke76 The testing builds an instance in the Rackspace Cloud and tests CentOS there. It doesn't matter what OS Travis-CI runs.

If you want the role and nothing else, you can easily clone this repository and copy out the roles directory. I'm not sure how far the other repo is actually behind this one.

[shawnsi]

@major Are we fundamentally incompatible with galaxy after dropping the separate role repository? I was using ansible-role-cis as a submodule directly in a roles directory and don't see a reason to break that structure. Were other users finding the repository separation problematic?

[major]

@shawnsi At the moment, yes. I received a bunch of requests to bring the role into the repository and remove the extra step of cloning the submodule.

[shawnsi]

@major I'll see if I can rework my submodule to play nice.

[Trikke76]

hi, not trying to push but any idea when this submodule would be ready , as i moved my fixes in our company github as this design is easier for galaxy and also to maintain my other roles in different github accounts.

https://github.com/Open-Future-Belgium/ansible-rhel-cis

if you can make a module that plays nice i prefer to use this one and push my contributions to it then to fork and maintain it next to this one.