wterm
wterm copied to clipboard
majestrate
Use pkg-config for wld
Is there a specific reason to include the wld sources in the git repository? I guess it means there are less dependencies to download, but I think we'd be better off with pkg-config (or at least prefer the users' library rather than the one included). This way we can update wld separately, plus lots of people might already have wld compiled (velox users).
NOTE: for some reason, this makes the repo unable to compile on Gentoo until I added the WLD links/sources AND the pixman sources (before WLD in the cflags). I think it has to due with the Makefile unable to look up the pixman sources at that point (was getting a lot of undefined references to pixman typedefs).
I'm not too particular on how it gets included (but a submodule might be better). I was more referring to the fact I'd just rather use my system WLD over the included WLD (via pkg-config) if it is available. Do you foresee any issues with that?
Do you foresee any issues with that?
possibly, I made some changes to WLD a while ago (forgot what they were) so I bundled WLD because the library seemed dead.
Gotcha. I just wanted to verify if there were customizations. I wanted to use the native wld on this system (using it with velox), but I'll stick with the one bundled with the repo.
On Mar 14, 2018 5:00 AM, "Jeff" [email protected] wrote:
Do you foresee any issues with that?
possibly, I made some changes to WLD a while ago (forgot what they were) so I bundled WLD because the library seemed dead.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/majestrate/wterm/issues/5#issuecomment-372996977, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs_ioqIrJi705vbBrb5AEDvZNqlS-Ysks5teQZ2gaJpZM4SpFi9 .