csiphash icon indicating copy to clipboard operation
csiphash copied to clipboard

more portable le64toh()

Open dankogai opened this issue 12 years ago • 5 comments

Instead of checking OS platforms, it directly asks cpp for the endianness. That way the code should be more portable. Worked not only for OS X, FreeBSD and Linux but also Windows.

Dan

dankogai avatar Feb 18 '13 23:02 dankogai

Please use the latter. The former had an embarrassing typo.

Dan

dankogai avatar Feb 19 '13 01:02 dankogai

I'm not convinced. I prefer simplicity over portability.

majek avatar Feb 19 '13 16:02 majek

How about d493cb336d348c007952e9909428d03fc941658f ?

majek avatar Feb 24 '13 03:02 majek

Added NetBSD and OpenBSD to d493cb3

dankogai avatar Feb 24 '13 05:02 dankogai

The __BYTE_ORDER part was unconditionally define'd _le64toh as le64toh while OpenBSD defines that as letoh64. The latest patches address that.

dankogai avatar Feb 26 '13 04:02 dankogai