Matt Harding

Results 33 comments of Matt Harding

Alright, I've had a bash at fixing the spec. https://github.com/whatwg/html/pull/10505

I think the idea here is good, but it doesn't look quite right: your second circle is skinnier than the first one. There are also several pre-existing weird qualities of...

From above: ``` if (dc1 == 0xf) { return; } ``` Secret feature to skip the draw? This code seems to be really old, I think it's probably unintentional. ```...

Seems closely related to this issue: https://github.com/rust-lang/rustup/issues/1956

Hmm, is this really a problem? It's okay to be oversized during development.

Thanks for considering it! I've fixed the tests I broke, amended the commit and commit message and force pushed. Apologies to anyone who pulled the original commit.

There's always `rustup show active-toolchain [-v]`, although it is admittedly longer ```fish Matt@Matts-PC /c/d/p/r/rustup (show-order)> rustup show active-toolchain stable-x86_64-pc-windows-msvc (default) Matt@Matts-PC /c/d/p/r/rustup (show-order)> rustup show active-toolchain -v stable-x86_64-pc-windows-msvc (default) rustc...

As an aside, would it be possible to reformat the reason the active toolchain was chosen? At the moment the floating `(default)` is a little misleading and mysterious if you...

It's a little terse, I'll admit. I think because it's right next to the other parts of the active toolchain, you can work out what it's the reason for using...

Yes, that's definitely an improvement! Although I think we could do away with the blank lines after the `=====` and `-----` lines.