Etienne Marais

Results 103 comments of Etienne Marais

Investigating. It seems to be related to mdx internal issue.

We have two commits here to compare the working and broken behaviour: * Working: https://ci.ocamllabs.io/github/ocurrent/ocurrent/commit/cd9156e800915aac3149affaebd58518ee03f653/variant/alpine-3.15-4.14_opam-2.1 * Broken: https://ci.ocamllabs.io/github/ocurrent/ocurrent/commit/b75be989d67034e77e4a77316d342972d75ecc61/variant/alpine-3.15-4.14_opam-2.1

After digging into the investigation, the issue seems unrelated to`mdx`. Indeed, if you look at the last commit that works and the first one that breaks, you can see the...

Thanks to @art-w and @MisterDA, one solution has been found here: https://bugs.launchpad.net/ubuntu/+source/git/+bug/1993586. This idea authorises the [file](https://git-scm.com/docs/git-config#Documentation/git-config.txt-protocolallow) on the command line.

Thanks, the `context` argument is exactly what I would have need to achieve the `headers` part: I can totally fetch the `Context` in this branch to use it! :+1: However,...

Thanks for the clarifications! :pray: > the first thing to do is to add tests for this. this way, we can discuss concretely about how the messages look You are...

Hi @rgrinberg, Thanks for the feedback! > If this PR is adding a file that isn't a target of a rule, what prevents the file from being deleted by dune...

I removed the `headers` related parts to make this PR more atomic. @emillon There is now a cram test to ensure the mechanism would be broken on purpose. @Leonidas-from-XIV, I...

@Leonidas-from-XIV, I'm not sure about the path I should take with this. Indeed, if I add a verbose flag, the tests would pass, but the logging result is pretty big......

Thanks, @rgrinberg! For the tests, I'm updating them to use a file as @Leonidas-from-XIV suggested. It would make the ones concerned more resilient to output changes. Indeed, the goal of...