maintainer
maintainer copied to clipboard
Allow creating AUTHORS.md from local repo without using GitHub API
Hey @gaocegege :) You already have the necessary git
command and regex defined:
https://github.com/gaocegege/maintainer/blob/5f09778bcf080f106b77c2f07f6fa3a94bb47688/cmd/contributor.go#L34-L51
But you don't use them. I don't think that many people want to create a GitHub API token just for using maintainer. So this should be optional
There is a trade-off between ease of use and readability.
Now the Authors.md has the links to authors: https://github.com/gaocegege/maintainer/blob/master/AUTHORS.md. And maintainer's prior implementation without GitHub support does not have this feature.
Yeah I think it should be a opetion.
PS: the GitHub API token is not necessary for contributor command. It is needed for changelog command.
Thanks for your suggestion!
@gaocegege And why this happens?
> maintainer.exe contributor
2017/11/18 05:31:27 There is no config file defined.
2017/11/18 05:31:29 Error when creating AUTHORS.md: GET https://api.github.com/repos/coala/coala/contributors?page=1&per_page=100: 401 Bad credentials []
@gaocegege
Now the Authors.md has the links to authors
That's indeed nice! :)
Have you also thought about additional GitLab integration, like we do with GitMate?
Yeah but I have no experience in GitLab. I could have a try :)
Oh, it seems that we needs token now, my mistake.
@gaocegege I would like to collaborate a bit in maintainer
, also to get proper coala bears for it... And it's a nice chance to learn some Go dev ;) I will try to make some PRs regarding me ideas... And will create some Google Code-in tasks for those maintainer
based bears
Welcome! @userzimmermann
🎉
Is this issue abandoned?