Add assertion is-not-overflowing

[tylerbecks]

I verified this works by testing against a local codebase with failing and passing test cases.

[scalvert]

@tylerbecks thanks for the addition. I think the names don't match what your PR title says. The assertions appear to be isOverflown and isNotOverflown. These names don't represent correct english, and also are are past tense. It may be better to name them isOverflowing and isNotOverflowing, both present tense. What do you think?

[tylerbecks]

I originally had those names but didn't see any other assertions with the present participle. But agreed, real engilsh would be best. Updating!

[tylerbecks]

I had to run yarn upgrade because ember test was failing with this error:

yarn run v1.22.17
$ ember test
Environment: test
cleaning up...
Build Error (broccoli-persistent-filter:Babel > [Babel: ember-source]) in @ember/-internals/overrides/index.js

/Users/tbecks/Code/LinkedIn/qunit-dom/@ember/-internals/overrides/index.js: 'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).


Stack Trace and Error Report: /var/folders/t9/s271r3dn0vq71w83h31q9m680010cz/T/error.dump.db8174e787d8c867f07ef0ae3f0f4dd1.log
error Command failed with exit code 1.

[scalvert]

Does that mean master isn't passing?

I'd probably avoid running yarn upgrade, as it just does a whole hog upgrade of all your packages at once. At a minimum, I'd do that in a separate PR than this, in order to keep this PR focused. Can we do that instead, separately upgrade the necessary packages?

[tylerbecks]

@Turbo87 thanks for your review, just updated based on all your comments.

[tylerbecks]

Hey everyone 👋 just coming back from vacation and looping back to this.

I think my previous commit was a no-op and I provided a bit of context in a comment here: https://github.com/simplabs/qunit-dom/pull/1384

@scalvert @Turbo87 I'd love to circle back and get this merged if everything looks good.

@Turbo87 We had a rocky start but hopefully I still have a chance to make you fall in love with me.

[scalvert]

LGTM. Interested in @Turbo87's review.

[Turbo87]

looks generally alright, although I'm uncertain how useful this assertion will ultimately be. since it potentially depends on the browser window size and other dynamic factors it seems a bit brittle to me on first glance.