ember-simple-auth icon indicating copy to clipboard operation
ember-simple-auth copied to clipboard

Migrate Mocha to Qunit

Open BobrImperator opened this issue 4 years ago • 3 comments

We should migrate tests to use Qunit instead of Mocha. Qunit is more standardized in the community, also ember-mocha is not actively maintained which is causing issues with embroider builds. While embroider could potentially be fixed in mocha, we believe that Qunit will be more appealing for people who'd want to chip in into development of ESA.

closes #2242

BobrImperator avatar Aug 18 '21 22:08 BobrImperator

@BobrImperator how do you pretend to start this? Create an initial PR with setup, them appending multiple other PR's with the refactorings?

If you do the setup I could help rewriting these specs ;)

brunoocasali avatar Sep 24 '21 15:09 brunoocasali

I was thinking about doing simply a big 💥 since the work is actually quite simple for the most part. I'd need to see how we could split the work if you're interested in helping out.

BobrImperator avatar Sep 28 '21 17:09 BobrImperator

Yes I am! hacktoberfest is closer 👯. We could create a big PR at the end, but multiple small PRs that merge into the big one... Probably will be easier to review.

brunoocasali avatar Sep 28 '21 18:09 brunoocasali

closed by https://github.com/mainmatter/ember-simple-auth/pull/2330

BobrImperator avatar Feb 06 '23 13:02 BobrImperator