100-exercises-to-learn-rust icon indicating copy to clipboard operation
100-exercises-to-learn-rust copied to clipboard

Fix typos in 03_ticket_v1/12_outro test

Open oliverbarnes opened this issue 1 year ago • 5 comments

oliverbarnes avatar Oct 13 '24 17:10 oliverbarnes

Deploy Preview for taupe-lily-3539f6 ready!

Name Link
Latest commit 4b2bd5e1ca36a3b67d3194a4624cae7688d11f66
Latest deploy log https://app.netlify.com/sites/taupe-lily-3539f6/deploys/670c0fdea5437b0008b501fc
Deploy Preview https://deploy-preview-170--taupe-lily-3539f6.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 13 '24 17:10 netlify[bot]

The build is failing when trying to checkout https://github.com/mainmatter/core-sans-a-fonts. Error says the checkout action doesn't find the default branch, but when explicitly setting the branch as 'main', it doesn't find the repo at all.

(I've since removed the troubleshooting commit that tried to set the ref)

Found these related issues, but no clear solution (to me) - might be related to permissions:

https://github.com/actions/checkout/issues/347 https://github.com/actions/checkout/issues/417

I'm setting this PR as draft until I'm able to resolve it. Luca, hopefully you'll have a clear idea of what's going on :)

oliverbarnes avatar Oct 13 '24 18:10 oliverbarnes

I don't know about the permissions (@marcoow?), but the refs there are intentional! At this stage we haven't yet discussed Copy types.

LukeMathWalker avatar Oct 14 '24 05:10 LukeMathWalker

Yeah, you don't have access to the repo from a fork – I see that's a bit limiting, maybe we shouldn't be building the PDF on forks or use a fallback font or so…

marcoow avatar Oct 14 '24 06:10 marcoow

@LukeMathWalker wdyt? Shall we just build main?

marcoow avatar Oct 14 '24 06:10 marcoow

We could use a fallback font, so that we are sure it builds correctly at the very least.

LukeMathWalker avatar Oct 14 '24 06:10 LukeMathWalker

yeah I agree that's better 👍

marcoow avatar Oct 14 '24 07:10 marcoow

but the refs there are intentional! At this stage we haven't yet discussed Copy types.

Ok! I wasn't familiar with values as references like this :) I'll close this and go back to the exercise, then

oliverbarnes avatar Oct 14 '24 09:10 oliverbarnes