foe-helfer-extension
foe-helfer-extension copied to clipboard
Statistics messed in guild memeber stat on Guild Buildigs page
In the detailed view on the Guild Buildings page, the statistics were incorrect. For example, in the summary, I could see 76 arcs in the guild, but in the detailed view, there were only 60 members with arcs.
After a little investigation, the problem was locally fixed by changing one line of code in guildmemberstat.js:
Original source code (in ShowGuildBuildings):
let buildingID = helper.str.cleanup(obj.member) + '' + obj.gbid;
Fixed line:
let buildingID = `${obj.player_id}-${obj.gbid}`;
After this change, everything worked fine.
If you could incorporate this fix into the main code, we would be grateful. :)
PS: to be more informative about this bug - for some members helper.str.cleanup(obj.member) return empty string, so buildingId became not unique. While player_id is fine for all cases.