Is lockfile a unused dependency?

Open yuluc1234 opened this issue 4 years ago • 1 comments

Hi There seems to be no code in the source code that uses "lockfile". But in “requirements-with-deps.txt”, "lockfile" is still listed as a dependency. The following commit removed "import lockfile" in "mailpile/spambayes/safepickle.py ". Switch to using existing dependancy "fasteners" for locking So should it be removed from "requirements-with-deps.txt"?

Jun 29 '21 11:06 yuluc1234

I'm not the authority, but I believe that you are correct. IIRC fasteners was introduced when code was added to prevent two Mailpile instances from using the same homedir.

Jun 30 '21 15:06 JackDca