Mailpile icon indicating copy to clipboard operation
Mailpile copied to clipboard

should biplist be listed as dependency

Open suliuzh opened this issue 4 years ago • 2 comments

Hi I am wondering if biplist should be listed in setup.py or requirements,txt? As we can see, biplist is used in packages/macos/dmgbuild-settings.py as a must. So should biplist be listed as dependency? image

suliuzh avatar Nov 11 '20 05:11 suliuzh

@suliuzh I've added this to the dev requirements.txt as it looks like this is a dependency only used when building packages not for production.

ooojpeg avatar Oct 17 '21 19:10 ooojpeg

Thanks for your nice reply. It seems that there are other requirements that are not declared?

  • PySide https://github.com/mailpile/Mailpile/blob/c9bd0018e7ef16bbc2e417f54e4ff3624767c5e6/scripts/mailpile-pyside.py#L8

  • email https://github.com/mailpile/Mailpile/blob/c9bd0018e7ef16bbc2e417f54e4ff3624767c5e6/mailpile/plugins/compose.py#L2

suliuzh avatar Feb 16 '22 07:02 suliuzh