Mailpile icon indicating copy to clipboard operation
Mailpile copied to clipboard

Textpart scanning for valid url and list of trusted urls of common file sharing sites

Open deepak21188 opened this issue 6 years ago • 2 comments

We are a group of students. We studied the architecture of Mailpile as a part of software architecture and documentation course. We are doing this pull request as a part of our assignment. The pull request is regarding the issue https://github.com/mailpile/Mailpile/issues/2204. We have tried to complete certain tasks mentioned in https://github.com/mailpile/Mailpile/issues/2204#issue-403099577. List of tasks done as follows:

  1. Resolved FIXME: Scan text parts for URLs, in search.py
  2. Created a list of trusted URL regexps of common file sharing sites
  3. Set prefs.attachment_urls defaults in mailpile.plugins.setup_magic

deepak21188 avatar Apr 08 '19 01:04 deepak21188

Thank you for doing this!

I have to warn you it may take me some time to get a review done; I have been taking some time off from this project and there is a bit of a back-log of issues and PRs that need my attention. My first impression is that you've done good work here, but please be sure your supervisor understands that I may not be able to respond right away.

It would be a shame if you missed out on credits because I'm unresponsive.

BjarniRunar avatar Apr 08 '19 23:04 BjarniRunar

Thank you so much! The guideline for the assignment says that the pull request does not have to be accepted for grading, hence, we are not worried about that.

deepak21188 avatar Apr 09 '19 01:04 deepak21188