Double-check UI behaviours

[BjarniRunar]

This is a list of things we need to double-check before we make a release. Some of these points might be OK, some might need coding to fix.

• [ ] Deleting a draft from /in/drafts/ does not delete the whole thread
• [x] Manually tagging as Draft or Outbox is blocked (#864)
• [ ] Removing from the Outbox makes message editable again
• [x] Per-mailbox and per-account tags cannot be removed from a message
• [x] Tagging of messages in the Browser view is blocked (#1694)
• [ ] Figure out why the result cache sometimes fails to update the sidebar / main view
• [x] Make sure notifications don't hang forever after attachment download
• [x] Page title does not change while navigation with auto-ajax enabled
• [ ] Check whether autosave misbehaves if you have "quoted replies" disabled
• [ ] When creating a Saved Search, the page fails to refresh even if it succeeds
• [x] Ensure the Reply button replies to the currently displayed message (within a thread)
• [x] Make password input dialog go away after input, if it was opened automatically
• [ ] The OAuth copy-paste dialogue is confusing: should hide the input field at first
• [ ] Parent link in browser is wrong at times, especially on multipile
• [ ] Discovered over N mailboxes popup pertains to/effects wrong mail source, loops

(more will be added as they occur to me)

[JocelynDelalande]

Some of them had been fixed since, this list needs some ticking :-)

[JackDca]

Comments on some of the items listed above:

Deleting a draft from /in/drafts/ does not delete the whole thread.

Tried this on a long thread - composed forwarded message to a new addressee, saved it, put it in Trash. Other messages in thread were not affected.

2019-07-23: In response to questions from @BjarniRunar, I tried various ways of creating drafts and then trashing them from the Drafts folder including: creating the draft by replying the 2nd last item in the thread in Message view, replying to the last item in the thread in Freshness view, forwarding in Message view, forwarding in Freshness view; opening the Drafts tag then dragging a draft message handle to the Trash, selecting a draft (using checkbox to the right) and then clicking selection action trash icon (at the top of the Compose window). Also opened drafts and clicked the trash icon at the bottom (beside Save and Send). In every case, only the draft was trashed, all other messages in the thread remained in the Inbox. There was one inconsistency: When the Reply button is used to create a new draft, the From: To: and Conversation display appears to the left of the message composition area (even if there is only one email in the thread and only one addressee), but that when the Forward button is used to create the new draft those elements are not displayed. This seems harmless, not sure if it is intentional.

Conclusion (unchanged): Check this item Done.

Removing from the Outbox makes message editable again

Testing showed that the sending of an email in the Outbox could be stopped by:

• Clicking the Outbox tag, selecting the email by clicking the checkbox at the right of the email entry, then clicking the "Untag" icon at the top of the list of emails; the email can be found again by searching using the contents of its subject line; or,
• Clicking the Outbox tag, clicking on the email subject, dragging the handle at the left of the email entry to the Inbox tag; the email can be found again by clicking the Inbox tag.
• Same as above, but click the "Trash" icon and find the email again by clicking the Trash tag.

Testing also showed that the sending of an email in the Outbox was not stopped by:

• Clicking the Outbox tag, dragging any of the the Drafts, Inbox or Drafts tags to the email entry. (Note that it is never possible to drag to the Drafts tag.)

In the above cases, when the sending was successfully interrupted, the message was no longer editable. Also attachments (if any) could be opened or saved, which is not the case when an email is editable (presumably because attachments in drafts are links, the actual contents are only added to the body of the email when the Send button is clicked) .

The process of waiting for the Outbox tag to appear in the sidebar (which sometimes takes a while), clicking on it, selecting the email, then clicking on the Untag icon is messy, and it has to be completed before the email is sent which is typically within 90 s (config.prefs.empty_outbox_interval). If we want to provide this capability, perhaps the Notification "Preparing to Send" should have an "A mistake? undo" button, just as in the notifications generated when the Untag or Move to Trash icons are clicked.

Suggestion: This item should be more clearly defined. Possibly, it should include giving the Notification an "undo" button; this should move the email from Outbox back to Drafts, make it editable, and revert the status of the attachments

Conclusion: This item needs work.

Figure out why the result cache sometimes fails to update the sidebar / main view.

Comment: This needs to be more clearly defined (with an example maybe?).

Ensure the Reply button replies to the currently displayed message (within a thread)

I've tested this - it seems to work correctly.

Conclusion: Check this item Done.

Tests were run on master commit e86d5ba8 dated 2019-07-11.