mailman icon indicating copy to clipboard operation
mailman copied to clipboard

TestingAdapter `deliver` function doesn't return the same type as ExternalSmtpAdapter

Open martinos opened this issue 8 years ago • 3 comments

The TestingAdapter.deliver function returns a Task, however the ExternalSmtpAdapter.deliver returns a tuple: {:ok, message}.

I think that both function should return the same type, it would make tests behave more like production code.

martinos avatar Apr 30 '16 04:04 martinos

+1 for this. Will be pointing to your branch until the PR goes through.

IamfromSpace avatar Jun 05 '16 22:06 IamfromSpace

@kamilc Is there a reason to have different results? Writing code with tests and matching against result isn't possible because of this

hamann avatar Jun 07 '16 21:06 hamann

👍 Experiencing the same issue here. Both adapters should return a Task.

zberkom avatar Aug 08 '16 21:08 zberkom