MailjetSwiftMailer
MailjetSwiftMailer copied to clipboard
MailjetTransport.php optimation
There are the following issues in the file MailjetTransport.php:
PHPDocs are wrong:
- some @parameters are not declared
- some @throws are not declared
- some @returns contain not all possible return types
- some @var use relative paths which can not be mapped by some IDE's e.g. (PHPStorm)
Logic:
- There is some logic which is unnecessary in the function bulkSend
Variables:
- $resultStatus is never used
- $sendCount is double declared
Please merge pull request #17 ;)
It would be really nice if I could get some kind of feedback ;)
ping @mailjet/dev-evangelist ?
Hey! I've added some ideas for improvement as we're on the optimisation topic. Please check the PR