MailjetSwiftMailer icon indicating copy to clipboard operation
MailjetSwiftMailer copied to clipboard

MailjetTransport.php optimation

Open kevinveenbirkenbach opened this issue 6 years ago • 4 comments

There are the following issues in the file MailjetTransport.php:

PHPDocs are wrong:

  • some @parameters are not declared
  • some @throws are not declared
  • some @returns contain not all possible return types
  • some @var use relative paths which can not be mapped by some IDE's e.g. (PHPStorm)

Logic:

  • There is some logic which is unnecessary in the function bulkSend

Variables:

  • $resultStatus is never used
  • $sendCount is double declared

kevinveenbirkenbach avatar Apr 10 '18 10:04 kevinveenbirkenbach

Please merge pull request #17 ;)

kevinveenbirkenbach avatar Apr 10 '18 11:04 kevinveenbirkenbach

It would be really nice if I could get some kind of feedback ;)

kevinveenbirkenbach avatar Apr 17 '18 12:04 kevinveenbirkenbach

ping @mailjet/dev-evangelist ?

Nightbr avatar Apr 17 '18 13:04 Nightbr

Hey! I've added some ideas for improvement as we're on the optimisation topic. Please check the PR

kachar avatar Apr 19 '18 14:04 kachar