talon Add support for Python 3.4

Apr 16 '15 10:04 afedosenko

+1

Apr 16 '15 10:04 longedok

Python 3 support will be great.

May 14 '15 23:05 tahseen

+1

Jul 07 '15 13:07 ddemid

+1

Aug 05 '15 17:08 maccman

:+1:

I am would like mark mailgun/talon require mailgun/flanker (lack python3 support) which require mailgun/expiringdict, which lack of python 3 support too.

Aug 25 '15 01:08 ad-m

Hi,

I've created a fork of talon, https://github.com/tictail/claw, in which I've removed the signature extraction that depends on ML (which I didn't use), and cleaned up some dependencies (now much less weird stuff installed). I've also started to implement some bug fixes, along with CI test suites and so on.

Flanker is only used in the tests, so to get Python3.4 support working would be to just find another way to run those tests.

Aug 25 '15 06:08 tgwizard

Hi all. Talon has been updated to have no flanker dependency. Could you please check compatibility with Python 3.4?

Sep 07 '15 11:09 obukhov-sergey

@obukhov-sergey , talon still require "lxml==2.3.3", but lxml < 3, are not python 3 compatible.

Sep 07 '15 20:09 ad-m

@obukhov-sergey , At https://github.com/ad-m/claw/tree/mailgun_talon I created fork of your repo, added TravisCi by python 2.7,3.3 and 3.4.

In .travis.yml I used conda package manager, due some performance issues (which make installations fails on Travis) for numpy, scipy and scikit-learn. Now it install fast enought.

Unfortuanetly, syntax of talon aren't python3 compatible. See for your code: https://travis-ci.org/ad-m/claw/jobs/79189172 .

I tried use 2to3 over talon code, but it still fails (see https://travis-ci.org/ad-m/claw/jobs/79186653 ).

Sep 07 '15 21:09 ad-m

Hi @ad-m, thanks. I've unpinned lxml version. Will try to address other comments as soon as possible but no ETA.

Sep 10 '15 18:09 obukhov-sergey

@obukhov-sergey , you have to add cssselect to dependencies too.

Sep 10 '15 18:09 ad-m

Hi, I started to port this to python3.4.3. I have a fork where it passes almost all tests. However, it isn't backwards compatible with 2.7 (the project that I need talon for only uses python3). Feel free to check it out. In the next few weeks, I'll try to make it backwards compatible.

Feb 01 '16 02:02 Sumeet-Jain

@Sumeet-Jain , thank you.

Feb 01 '16 02:02 ad-m

#97 does the work to make the parts of talon that don't use ML support Python 3.

Jul 13 '16 18:07 timabbott

Since this is still unsolved, I have a python 3 version of talon ready to go. All tests are passing from python 2.7 to python 3.6 although I had to modify some of the tests to assert against byte arrays instead of string, and to pass an encoding when opening unicode files on python 3.

I'll send in a PR shortly.

May 23 '17 23:05 yfilali