talon icon indicating copy to clipboard operation
talon copied to clipboard

Published 20 hours ago • verified publisher icon mailgun

Split non-ML part into a new talon-core package

Open andersk opened this issue 5 years ago • 4 comments

The nonstandard setup.py install --no-ml option didn’t work correctly with pip. We could move the ML dependencies into an extra, but that approach was previously rejected (#121): extras can’t be enabled by default, so it could have been disruptive to existing users. Instead, we split off a new talon-core package with no ML dependencies, and have talon re-export everything from it.

Fixes #130; fixes #131.

andersk avatar Oct 03 '19 01:10 andersk

Can one of the admins verify this patch?

mailgun-ci avatar Oct 03 '19 01:10 mailgun-ci

This is fantastic. Using the fork, but LGTM.

andrewelkins avatar Mar 26 '20 03:03 andrewelkins

Have this would be amazing. Any progress on merging this?

benbrandt avatar Sep 02 '20 20:09 benbrandt

@horkhe Can you please comment on whether this approach is acceptable for upstream? Zulip has been stuck on our fork of Talon for six years due to this issue and we would very much like to unfork it.

If this is acceptable, I’m happy to respin this for the current version.

andersk avatar May 02 '22 21:05 andersk