mailgun-ruby icon indicating copy to clipboard operation
mailgun-ruby copied to clipboard

Abandoned dependency: rest-client abandoned in 2019

Open jaredbeck opened this issue 1 year ago • 8 comments

This project depends on the rest-client gem. Unfortunately, rest-client has been abandoned. There haven't been any commits since 2019.

There are some unofficial forks but it might be better to switch to something modern and maintained like Faraday.

jaredbeck avatar May 31 '23 18:05 jaredbeck

Hi @Retttro / @mgrishko, I'm interested in seeing this resolved. Would you accept a PR switching out rest-client with faraday? There's already a wrapper class around responses with Mailgun::Response so backwards compatibility issues on that front should be minimal, if any.

One somewhat unfortunate consequence of this change is that faraday 2.x requires ruby 2.6 at the minimum and would requires this gem to bump its minimal supported ruby version from 2.2 to 2.6 as well. Ruby 2.5 is EOL since 31 Mar 2021, so almost 3 years now.

Alternatively, I could explore going with plain Net::HTTP which doesn't have this problem. It's not great to use in any way but should get the job done. One sore point in net-http itself is multipart requests (as in no support at all). There's multipart-post but I'd rather not include for this in a gem that others depend on. You get to the situation we are at here where every gem includes different http gems and the consumer suddenly has 10 different ones in their lockfile.

Personally I would much appreciate the possibility of going with faraday just so that I wouldn't have to interact with net-http directly.

Earlopain avatar Dec 18 '23 13:12 Earlopain

Hi @Earlopain. Thanks for your notes on this issue. I'm planning to make a PR with the transition to Faraday next month. I think we will release this at the end of January.

Retttro avatar Dec 18 '23 14:12 Retttro

Thanks for the quick response, I'm looking forward to that (:

Earlopain avatar Dec 18 '23 14:12 Earlopain

@Retttro Do you have any updates on this?

andreyzhelnin-st avatar Feb 26 '24 17:02 andreyzhelnin-st

It looks like Retttro doesn't work for/with mailgun anymore, if LinkedIn is to be believed. @mgrishko, can you give some insight here?

Earlopain avatar Apr 02 '24 11:04 Earlopain

@Earlopain over the next 1-2 months, I'll be making these fixes.

mgrishko avatar Apr 10 '24 08:04 mgrishko

@mgrishko Hi there! Any news?

n-rodriguez avatar Jul 25 '24 23:07 n-rodriguez

@mgrishko any progress on this topic?

KoenSengers avatar Sep 16 '24 12:09 KoenSengers

Still work in progress, sorry for the delay.

mgrishko avatar Oct 07 '24 10:10 mgrishko