flanker icon indicating copy to clipboard operation
flanker copied to clipboard

Disable writing parsetab files to disk.

Open jfly opened this issue 7 years ago • 7 comments

This fixes https://github.com/mailgun/flanker/issues/206.

Before this change, when multiple Python processes are simultaneously doing a from flanker.addresslib import address, it's possible for some of them to crash in ply code.

See https://github.com/dabeaz/ply/pull/184, where I attempted to work around this issue by changing ply. You can see in this comment: https://github.com/dabeaz/ply/pull/184#issuecomment-425413897 that the author of ply suggests two workarounds for this issue:

  1. Remove ply as a dependency in setup.py and copy the source code of ply into flanker.
  2. Disable writing parsetab files to disk when invoking yacc.
  1. seemed like the simpler solution to me, so that's what I've done here.

jfly avatar Sep 30 '18 20:09 jfly

Can one of the admins verify this patch?

mailgun-ci avatar Sep 30 '18 20:09 mailgun-ci

(Full disclosure, I haven't tested this at all because I'm not sure how to.)

jfly avatar Sep 30 '18 20:09 jfly

Bump! Any feedback on this PR?

jfly avatar Oct 22 '18 19:10 jfly

Bump!

jfly avatar Jan 08 '19 21:01 jfly

Bump! Can anyone take a look?

jfly avatar Mar 21 '19 02:03 jfly

Bump! Anyone got some time to take a look at this?

jfly avatar Jun 17 '19 21:06 jfly