PyBitmessage icon indicating copy to clipboard operation
PyBitmessage copied to clipboard

Make all object types have the same size limits

Open ghost opened this issue 9 years ago • 2 comments

The size limits of objects currently vary depending on their type. This makes it harder to create new versions of old object types as for instance a pubkey longer than 440 bytes will not be relayed. So I think the only limit should be the limit of 2**18 bytes.

ghost avatar Jan 25 '16 21:01 ghost

I can review the code but I need to discuss with other people if the limit removal is a good idea.

PeterSurda avatar Jan 25 '16 22:01 PeterSurda

This should not be changed unless ACKs are simultaneously limited to only be of object type msg. But it might make sense to document the current behavior.

For reference these are the current limits as implemented by PyBitmessage:

getpubkey (0): 42 <= size <= 200
pubkey (1): 146 <= size <= 440
msg (2): size <= 2**18
broadcast (3): 180 <= size <= 2**18 and version >= 2
anything else: size <= 2**18

ghost avatar Feb 13 '16 00:02 ghost