mailchimp-transactional-php
mailchimp-transactional-php copied to clipboard
mailchimp
Makes it compatible (deprecation errors free) with PHP 8.*
Please, we need this fix in packagist to avoid continuous deprecated warnings
I've made my own fork with php8 support. I can't wait. For fix:
composer rm mailchimp/transactional
composer require otis22/transactional
I've made my own fork with php8 support. I can't wait. For fix:
composer rm mailchimp/transactional composer require otis22/transactional
can you fix marketing too? https://github.com/mailchimp/mailchimp-marketing-php
@Akustik88 I'am sorry. Project does not have tests and I don't use this project in production. I can't be sure I fix it right.
Renaming $Configuration to $config makes no sense. It is pure personal preference and is totally unnecessary. Please fix them back to $Configuration.
This is not just personal preference. The code calls $this->config all over, and that property should be declared. As far as I can see it doesn't call $this->Configuration anywhere.
As @PaulMcML said, the change about $Configuration is also a fix about dynamic property creation, so could you please approve and merge this PR @necmettin ?
@jeremyoppus I don't have write access to this repository. All I did was comment.. We are all waiting for @Moishe I think.
I haven't worked at Mailchimp for over 2 years, unfortunately. I'll try to ping some folks.
One thing worth mentioning: as noted in the README, this repo doesn't accept PRs or issues. It's auto-generated from this repo: https://github.com/mailchimp/mailchimp-client-lib-codegen. You might get more traction opening a PR there.
I have actually talked to the support team twice, and they assured me that the team was working on it. And yet, it's been months.
On Fri, Jan 12, 2024, 19:45 Moishe Lettvin @.***> wrote:
One thing worth mentioning: as noted in the README, this repo doesn't accept PRs or issues. It's auto-generated from this repo: https://github.com/mailchimp/mailchimp-client-lib-codegen. You might get more traction opening a PR there.
— Reply to this email directly, view it on GitHub https://github.com/mailchimp/mailchimp-transactional-php/pull/8#issuecomment-1889629359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMV2E4MHIV32AQM4YBX7TYOFSB7AVCNFSM6AAAAAAYFIXQJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGYZDSMZVHE . You are receiving this because you were mentioned.Message ID: @.***>
This can be closed - the newer V1.0.50 has fixed this problem.
https://github.com/mailchimp/mailchimp-transactional-php/compare/v1.0.50...v1.0.59
Closing as this has been fix already see https://github.com/mailchimp/mailchimp-client-lib-codegen/pull/348
Please upgrade to the most recent version, thanks
@webkod3r Hello, when it will be fixed in mailchimp-marketing (https://github.com/mailchimp/mailchimp-marketing-php)? Please someone from mailchimp, alteady fix it :(
@webkod3r Hello, when it will be fixed in mailchimp-marketing (https://github.com/mailchimp/mailchimp-marketing-php)? Please someone from mailchimp, alteady fix it :(
Potentially worth linking this PR to that repo as an issue if you're experiencing it there. Not sure if that one relies on the transactional code so you may well be falling on deaf ears here.
@webkod3r Hello, when it will be fixed in mailchimp-marketing (https://github.com/mailchimp/mailchimp-marketing-php)? Please someone from mailchimp, alteady fix it :(
Hi there, thanks to your comment I realized that no one will help us :)
So I used a temporary fix by adding
#[\AllowDynamicProperties]
right before this line
https://github.com/mailchimp/mailchimp-marketing-php/blob/c1a38f7248d8de7de412418fed8dae759b9e4b97/lib/Configuration.php#L50
