mailchimp-client-lib-codegen icon indicating copy to clipboard operation
mailchimp-client-lib-codegen copied to clipboard

Update superagent npm dependency

Open backflip opened this issue 2 years ago • 6 comments

Description

The superagent dependency used (as well as its formidable dependency) is deprecated, leading to warnings on every npm install using @mailchimp/mailchimp_marketing.

Judging from https://github.com/visionmedia/superagent#upgrading-from-previous-versions, there should be no breaking changes and my own tests consuming @mailchimp/mailchimp_marketing are still running fine.

Known Issues

I'm unable to run npm run generate on my machine, it exits with the following error:

[main] ERROR io.swagger.codegen.DefaultGenerator - Could not process model 'inline_response_200_14'. Please make sure that your schema is correct!
java.lang.NullPointerException: Cannot read field "isContainer" because "cp" is null

This might be related to using [email protected] due to v2 not being installable on my ARM Apple.

backflip avatar Jul 01 '22 15:07 backflip

Contributor License Agreement Instructions Thanks for your pull request. Before we can review your work, you’ll need to sign a Contributor License Agreement (CLA).

Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at [email protected]. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ if you need support.

Individual CLA: Mailchimp Individual CLA Corporate CLA: Mailchimp Corporate CLA

Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it.

What to do if you already signed the CLA Individual signers • If you’ve previously sent us a signed CLA, please reply here letting us know and we’ll verify. If we are unable to verify, It’s possible we don’t have your GitHub username or you’re using a different email address on your Git commit. Check that the CLA you previously submitted was sent to us using the email address associated with your GitHub username and verify that your email is set on your Git commits. Corporate signers • Your company has a Point of Contact (POC) who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you’ve previously sent us an updated CLA, please reply here letting us know and we’ll verify. • The email used to register you as an authorized contributor must be the email used for the Git commit. • The email used to register you as an authorized contributor must also be attached to your GitHub account.

cla-bot[bot] avatar Jul 01 '22 15:07 cla-bot[bot]

CLA signed and sent

On 1 Jul 2022, at 17:04, cla-bot[bot] @.***> wrote:

Contributor License Agreement Instructions Thanks for your pull request. Before we can review your work, you’ll need to sign a Contributor License Agreement (CLA).

Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at @.*** @.***>. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ https://mailchimp.com/contact/ if you need support.

Individual CLA: Mailchimp Individual CLA https://eep.io/assets/yzco4xsimv0y/5oXiQulP7Bqe9kPtulXiHR/254a0208cf46a5c438d75dd00db99668/Mailchimp_Individual_CLA.pdf Corporate CLA: Mailchimp Corporate CLA https://eep.io/assets/yzco4xsimv0y/5fCjtPRrjSMfFZmuufPnyg/7c59a766f7b1d6447ae4b645e77b3bd5/Mailchimp_Corporate_CLA.pdf Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it.

What to do if you already signed the CLA Individual signers • If you’ve previously sent us a signed CLA, please reply here letting us know and we’ll verify. If we are unable to verify, It’s possible we don’t have your GitHub username or you’re using a different email address on your Git commit. Check that the CLA you previously submitted was sent to us using the email address associated with your GitHub username and verify that your email is set on your Git commits. Corporate signers • Your company has a Point of Contact (POC) who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you’ve previously sent us an updated CLA, please reply here letting us know and we’ll verify. • The email used to register you as an authorized contributor must be the email used for the Git commit. • The email used to register you as an authorized contributor must also be attached to your GitHub account.

— Reply to this email directly, view it on GitHub https://github.com/mailchimp/mailchimp-client-lib-codegen/pull/302#issuecomment-1172441579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE7WW2U3MRQVLXTS6AW37DVR4CIFANCNFSM52NANULQ. You are receiving this because you authored the thread.

backflip avatar Jul 01 '22 15:07 backflip

@mc-keith @shogren could someone take a look at this issue? superagent is now at version 8.0.9

nbouvrette avatar May 15 '23 19:05 nbouvrette

@shogren please take a look

Stanzilla avatar Jul 15 '23 01:07 Stanzilla

please merge this

emmekappa avatar Oct 05 '23 09:10 emmekappa

This is open now 2 years. Please merge...

TanjaBayer avatar Jun 24 '24 08:06 TanjaBayer