mailchain icon indicating copy to clipboard operation
mailchain copied to clipboard

paging

Open todo[bot] opened this issue 7 years ago • 4 comments

https://github.com/mailchain/mailchain/blob/54ba08e962c3204d348ce307fcbf0bfcd8a46f29/internal/pkg/clients/etherscan/receiver.go#L38-L43


This issue was generated by todo based on a TODO comment in 54ba08e962c3204d348ce307fcbf0bfcd8a46f29 when #35 was merged. cc @robdefeo.

todo[bot] avatar Apr 14 '19 11:04 todo[bot]

related to #48

robdefeo avatar Aug 26 '19 18:08 robdefeo

Etherscan API docs indicate that it returns a maximum of 1000 results per API call https://etherscan.io/apis#accounts this in the short term reduces the need for paging the backend service but it does give a reliable solution. Either an address index service needs to be created or this needs to be resolved ref #251

robdefeo avatar Sep 07 '19 11:09 robdefeo

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please reply in order to keep the issue open. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

stale[bot] avatar Feb 20 '20 20:02 stale[bot]

This issue has been reopened because the TODO comment still exists in internal/clients/mailchain/receiver.go, as of ffa1846a93e251b7e043f679bdf22bd0d893bf54.


If this was not intentional, just remove the comment from your code. You can also set the reopenClosed config if you don't want this to happen at all anymore.

todo[bot] avatar Jul 12 '20 18:07 todo[bot]