mailchain icon indicating copy to clipboard operation
mailchain copied to clipboard

Ethereum sender without schema causes error.

Open robdefeo opened this issue 6 years ago • 4 comments

Is your feature request related to a problem? Please describe. When using a send and not specifying a schema (http/https) it causes an error when trying to serve the application.

Error: Could not configure senders: dial unix mainnet.infura.io/v3/570cf8a25e5442808857846eaecca321: connect: no such file or directory

Describe the solution you'd like One or more of the following.

  • Either validation when configuring endpoint
  • More explanation when configuring endpoint
  • More descriptive message in error

Describe alternatives you've considered N/A

Additional context N/A

robdefeo avatar May 29 '19 19:05 robdefeo

The scope of this issue has changed with the way that configurations settings are no performed. However the error can still appear when reading a value that is not valid. The url can be parsed to see if its valid then return an error explaining the issue. Taking the response of url.Parse and wrapping it with a more meaningful error.

e.g.

_, err := url.Parse(address)
if err!= {
   return errors.WithMessage(err, "address must be a valid URL")
}

In https://github.com/mailchain/mailchain/blob/d89f8eb7e82ae788aea5c56f3763cc3b05e8cb8f/sender/ethrpc2/ethrpc.go#L29-L34

robdefeo avatar Oct 12 '19 19:10 robdefeo

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please reply in order to keep the issue open. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

stale[bot] avatar Jun 10 '20 08:06 stale[bot]

Hey ,

Could you please assign this issue to me ?

Regards Shivani

sa3664 avatar Mar 20 '21 13:03 sa3664

Sure thing @sa3664, thank you for your interest and let us know if you have any questions.

tboeckmann avatar Mar 20 '21 14:03 tboeckmann