mailinabox
mailinabox copied to clipboard
mail-in-a-box
Another php8.1 upgrade
This is my take on upgrading to PHP 8.1 with the feedback from @kiekerjan's PR #2309.
Would probably like to move the PHP Version from the if on line 94 in nextcloud.sh and make it an additional mandatory argument for the InstallNextcloud() function. But to keep this PR simple initially I have foregone that.
- this has explicit PHP version as requested in https://github.com/mail-in-a-box/mailinabox/pull/2309#issuecomment-1745650977 and https://github.com/mail-in-a-box/mailinabox/pull/2309#issuecomment-1769586360
- have not made use of docker #2319
- not modifying the nextcloud package https://github.com/mail-in-a-box/mailinabox/pull/2309#issuecomment-1782382428
I have tested this with upgrading from a v57a backup (nextcloud 20.0.14) successfully.
Just double-checking, there are no backward incompatible changes between v8.0 and v8.1 in our repo? https://www.php.net/manual/en/migration81.incompatible.php
Just double-checking, there are no backward incompatible changes between v8.0 and v8.1 in our repo? https://www.php.net/manual/en/migration81.incompatible.php
These are covered in the individual packages.
Roundcube 1.6 introduced PHP 8.1 and is backwards compatible with 8.0.
Z-Push 2.7.1 Fixed the only PHP 8.1 specific issue that has been come across. There is still PHP 8.0 errors coming up and being fixed though. 2.7.4 has some more of these. Z-Push will be aiming to maintain PHP 7.4 to latest PHP.
I don't think there are any problems with moving to 8.1.
Great, thanks. Will leave it to @JoshData to review + merge, then I will do the next part, the NC upgrade.
@JoshData Since there was a new release, I wonder why this isn't merged yet?
My guess is that I haven't nailed it and it will take alot of Josh's time to review and provide guidance.
Probably more than him doing the work himself.
I wasn't going to chase him up, and give him the space to get to it when he can.
@matidau Fair enough, but it's been one month, MiaB has 14k followers and when it comes to security + emails, we shouldn't be using deprecated libraries. Give him a little nudge, please.
@binarykitchen If you feel strongly about it the best path would be to fork it yourself.
I won't be chasing Josh up, I value his time to work on what he deems important. 😊
@matidau Well, thanks, but no, thanks, forking isn't a proper solution either. Starting from zero isn't a good idea. I prefer to collaborate, to work together as a team.