mailinabox icon indicating copy to clipboard operation
mailinabox copied to clipboard

Published 20 hours ago • verified publisher icon mail-in-a-box

Allow users to specify a custom DKIM selector

Open bilogic opened this issue 1 year ago • 2 comments

  • Continuation of #2349 which was closed due to my accidental deletion of the branch
  • Also relies on storage-root-config #2382

To make it easier for the reviewer(s),

  1. auto format commits have no changes in logic
  2. https://github.com/mail-in-a-box/mailinabox/pull/2383/commits/a7beb721680d405f86567ba001caecdb5eb2fe7e and before are for PR #2382
  3. DKIM selector code changes are found in only 1 commit https://github.com/mail-in-a-box/mailinabox/pull/2383/commits/12f1486141be961af7af9a1872552388a549d045, which basically replaces the hardcoded selector with a variable

bilogic avatar Apr 21 '24 10:04 bilogic

Sorry I'm not going to allow putting the setting in mailinabox.conf. It has to go somewhere in STORAGE_ROOT so that it's backed up.

JoshData avatar Dec 22 '24 13:12 JoshData

Ok, how about STORAGE_ROOT/config.d/override.conf?

It would be great to get faster feedback. I had to read up what this was all about before being able to answer. :)

bilogic avatar Dec 23 '24 02:12 bilogic

Is there any progress on this

kalungia avatar Jun 19 '25 16:06 kalungia