mailinabox
mailinabox copied to clipboard
custom DKIM selector
Fixes https://github.com/mail-in-a-box/mailinabox/issues/2348
Allows us to avoid a DKIM TXT record clash when in use with other sending servers. Thank you.
@JoshData is this ok?
I would like to avoid using /etc/mailinabox.conf for new settings and put the settings in $STORAGE_ROOT, e.g. $STORAGE_ROOT/mail/dkim/selector.txt.
/etc/mailinabox.conf isn't included in backups and was meant for really low-level settings needed to do automated installs like the IP address.
ok, let me take a look as it has been a while :)
@JoshData
I had a look.
Using $STORAGE_ROOT/mail/dkim/selector.txt would scatter configuration over alot of files. e.g. I have another PR trying to adjust TTL
How about $STORAGE_ROOT/mailinabox.conf, with it taking priority over /etc/mailinabox.conf?
@JoshData
How about
$STORAGE_ROOT/mailinabox.conf, with it taking priority over/etc/mailinabox.conf?
I'm of the view that this is the best way forward and have filed a PR to demonstrate it.
This would mean, we still have to add all settings into /etc/mailinabox.conf, but they can be optionally overridden and backed up by $STORAGE_ROOT/mailinabox.conf
Does this address all your concerns? Thank you!
also brought this PR up to v68, ready to be merged
I would like to avoid using /etc/mailinabox.conf for new settings and put the settings in $STORAGE_ROOT, e.g. $STORAGE_ROOT/mail/dkim/selector.txt.
/etc/mailinabox.conf isn't included in backups and was meant for really low-level settings needed to do automated installs like the IP address.
@JoshData what do you think of #2383? thanks