ashes icon indicating copy to clipboard operation
ashes copied to clipboard

Compare to the LinkedIn fork

Open webmaven opened this issue 10 years ago • 4 comments

LinkedIn has forked Dust.js because the original developer/maintainer isn't responsive.

Given the number of improvements LinkedIn have made, it might be better to compare your compatibility to their fork.

webmaven avatar Nov 03 '14 11:11 webmaven

Hehe, definitely, and that's a fair enough point. Last I checked, many/most of LinkedIn's improvements are really just plugins/extensions built in dust, and not actual changes to the language behavior. I have a set of tests dedicated to a few of the most important new features I've pulled over, have a look:

https://github.com/mahmoud/ashes/blob/master/tests/new_features.py https://github.com/mahmoud/ashes/blob/master/tests/comp_helpers.py

mahmoud avatar Nov 05 '14 10:11 mahmoud

That's good to know! I suppose What I really meant is making sure you're drawing the comparison in the docs, including the README, to indicate you're maintaining compatibility with the active fork.

webmaven avatar Nov 05 '14 12:11 webmaven

Just saw this in the issues list. I had actually done this several months before -- https://github.com/mahmoud/ashes/wiki/Compatibility-with-LinkedIn-Dust.JS-Fork

jvanasco avatar Jun 23 '15 23:06 jvanasco

oh there is also a Compatibility file that was pulled into trunk from a PR I made a while back -- https://github.com/mahmoud/ashes/blob/master/COMPATIBILITY.md

jvanasco avatar Jun 24 '15 19:06 jvanasco