Marcel Hibbe

Results 478 comments of Marcel Hibbe

i think i was on the wrong track here. While it would still make sense to keep the session for this case (might be improved), the true error seems to...

no this is not yet implemented. I guess we could use this also for app shortcuts like https://developer.android.com/guide/topics/ui/shortcuts but i didn't yet have a look what the pitfalls could be...

@jakobroehrl how did you join the calls that are started? by notification or by manually clicking the phone button in the chat?

couldn't find it yet but i'm on it everytime i find a free minute..

ok got it. whenever you leave the chatview and you are NOT dialing, it's triggered to leave the room. see https://github.com/nextcloud/talk-android/blob/master/app/src/main/java/com/nextcloud/talk/controllers/ChatController.kt#L1582 But leaving the room fails because of https://github.com/nextcloud/talk-android/issues/1725 So...

can not reproduce this... can you, @nickvergessen ?

aaah you mean the appbar header. so the error you describe is in step 4...

i guess in short term the line `showShareToScreen = !showShareToScreen && hasActivityActionSendIntent();` in https://github.com/nextcloud/talk-android/blob/master/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java#L360 might cause the bug and could be changed. But the best solution for this would be...

> i guess in short term the line > > `showShareToScreen = !showShareToScreen && hasActivityActionSendIntent();` > > in https://github.com/nextcloud/talk-android/blob/master/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java#L360 > > might cause the bug and could be changed. might...